[1.17.1.0/7.9.0_0012] [Fixed] Broken carousel XVM ArcadeCamera_create hook issue

[^CHAMPi^ 38]

In the case of the issue the following happens: Every other mod that hooks into the ArcadeCamera create method and is executed before the XVM hook of Arcade camera and returns all parameters of the original method (as it always should be for every mod hook!) will cause this issue. The XVM hook is called with one more parameter as it expect and then it happens:

TypeError: _ArcadeCamera_create() takes at most 4 arguments (5 given)

 

orignal ArcadeCamera

def create(self, onChangeControlMode=None, postmortemMode=False, smartPointCalculator=True):

 

XVM hook of ArcadeCamera: (xvm-master\src\xpm\xvm_battle\camera.py)

def _ArcadeCamera_create(base, self, onChangeControlMode = None, postmortemMode = False):

 

Please fix this issue because there are other mods out there that also using that hook to change cam stuff. Even if you don't need the smartPointCalculator parameter for your method you need to expect it in your hook or XVM will break the hook chain.

 

Of course you also need to change the call to the base method at the end of your method from:

base(self, onChangeControlMode, postmortemMode)

 

to 

base(self, onChangeControlMode, postmortemMode, smartPointCalculator)

btw: Please stop to recommend to install xvm alone. No one will do this 

 

 

Edited August 11, 2022 by Mixaill

[yepev 291]

@^CHAMPi^ you can submit your fix to the XVM repository. Just make a pull request. 

[Kurzdor 466]

https://gitlab.com/xvm/xvm/-/merge_requests/450