Napalm Posted August 4, 2016 Share Posted August 4, 2016 (edited) Hello, I think i found a bug in your code of tankcarousel.py. My xvm.log contains the following message for multiple times: 2016-08-05 01:19:36: [ERROR] Traceback (most recent call last): File "xvm_tankcarousel/tankcarousel.py", line 110, in carousel_data_provider_vehicleComparisonKeyNameError: global name 'vehicles_stats' is not defined I searched your repository for the file and found the following code in it: if sort_criterion == 'winRate': stats = vehicles_stats.get(vehicle.intCD) comparisonKey.append(factor if stats else 0) if stats: winrate = float(stats.wins) / stats.battlesCount The object vehicles_stats is not defined before using. The sorting critera "winrate" is without effect except a message in the log. I posted here because I did not find a bugtracker. If there is any it would be nice if someone gives me the url. Best regards Napalm Edited August 4, 2016 by Napalm @ Quote Link to comment Short link Share on other sites More sharing options...
13 Posted August 5, 2016 Share Posted August 5, 2016 Hi. First of all, thank you. I posted here because I did not find a bugtracker. If there is any it would be nice if someone gives me the url. You can post all found bugs in this section. I've moved your topic. Also, if you want help us with code, there is a way to suggest your code directly into our repo. @ Quote Link to comment Short link Share on other sites More sharing options...
sirmax Posted August 5, 2016 Share Posted August 5, 2016 Thanks, fixed. @ Quote Link to comment Short link Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.