Bug in tankcarousel.py

[Napalm 1]

Hello,
 
I think i found a bug in your code of tankcarousel.py.
 
My xvm.log contains the following message for multiple times:

2016-08-05 01:19:36: [ERROR] Traceback (most recent call last):
  File "xvm_tankcarousel/tankcarousel.py", line 110, in carousel_data_provider_vehicleComparisonKey
NameError: global name 'vehicles_stats' is not defined

 

I searched your repository for the file and found the following code in it:

            if sort_criterion == 'winRate':
                stats = vehicles_stats.get(vehicle.intCD)
                comparisonKey.append(factor if stats else 0)
                if stats:
                    winrate = float(stats.wins) / stats.battlesCount

 

The object vehicles_stats is not defined before using. The sorting critera "winrate" is without effect except a message in the log.

 

I posted here because I did not find a bugtracker. If there is any it would be nice if someone gives me the url.

 

Best regards

Napalm

Edited August 4, 2016 by Napalm

[13 3,395]

Hi. First of all, thank you.

 

I posted here because I did not find a bugtracker. If there is any it would be nice if someone gives me the url.

 

You can post all found bugs in this section. I've moved your topic.

 

Also, if you want help us with code, there is a way to suggest your code directly into our repo.

[sirmax 5,499]

Thanks, fixed.